Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in docstrings of "pygmt.Figure.histogram" #2457

Merged
merged 7 commits into from
Mar 26, 2023

Conversation

yvonnefroehlich
Copy link
Member

Description of proposed changes

This PR aims to fix some typos in the docstrings of pygmt.Figure.histogram.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@yvonnefroehlich yvonnefroehlich added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Mar 23, 2023
@yvonnefroehlich yvonnefroehlich added this to the 0.9.0 milestone Mar 23, 2023
@yvonnefroehlich yvonnefroehlich self-assigned this Mar 23, 2023
@yvonnefroehlich yvonnefroehlich added the needs review This PR has higher priority and needs review. label Mar 25, 2023
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current changes look good to me. Remove "WIP" from PR title?

@yvonnefroehlich yvonnefroehlich changed the title WIP: Fix typos in docstrings of "pygmt.Figure.histogram" Fix typos in docstrings of "pygmt.Figure.histogram" Mar 26, 2023
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Mar 26, 2023
@seisman seisman merged commit 9af83e5 into main Mar 26, 2023
@seisman seisman deleted the fix-typos-24-histogram branch March 26, 2023 23:46
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants