-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename tutorial files to prevent duplicate file names #2260
Conversation
I don't think I like the new names. The |
I don't feel that strongly about it. I figure that adding @GenericMappingTools/gmt-maintainers Thoughts? |
I would prefer @willschlitzer's solution. |
I like the grouping-effect due to adding |
All these files are in the |
Ping @weiji14 and @maxrjones for their thoughts and preferences on this, please. |
I almost prefer a third option - prefixing with the sequence number of the tutorial (i.e. 👍 Prefix with |
Prefixing with numbers sounds like a good idea, but the contour tutorial may not be the 2nd tutorial when we add more tutorials in the future, so we may have to rename it in the future. |
I think I am OK with numbers as prefix. |
Changed to use numbers. |
This adds "tutorial_" to the start of
first_figure.py
andcontour_map.py
to avoid naming conflicts when building documentation.Fixes #2250
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version