Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline example to load_earth_geoid #2258

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Conversation

willschlitzer
Copy link
Contributor

Add an inline example to load_earth_geoid().

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Dec 20, 2022
@willschlitzer willschlitzer added this to the 0.8.0 milestone Dec 20, 2022
@willschlitzer willschlitzer self-assigned this Dec 20, 2022
@willschlitzer willschlitzer mentioned this pull request Dec 20, 2022
65 tasks
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after fix the typo.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Dec 21, 2022
@seisman seisman merged commit d460d7b into main Dec 21, 2022
@seisman seisman deleted the inline-example/load-earth-geoid branch December 21, 2022 09:07
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants