Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_earth_relief: Move parameter use_srtm after data_source #2230

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

willschlitzer
Copy link
Contributor

This moves use_srtm below data_source in the load_earth_relief docstring

Addresses #2225

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Dec 6, 2022
@willschlitzer willschlitzer added this to the 0.8.0 milestone Dec 6, 2022
@willschlitzer willschlitzer self-assigned this Dec 6, 2022
@seisman
Copy link
Member

seisman commented Dec 6, 2022

Please also move use_srtm after data_source in the function definition at line 19.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Dec 6, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 7, 2022
@seisman seisman changed the title Move use_srtm below data_source in load_earth_relief docstring load_earth_relief: Move parameter use_srtm below data_source Dec 7, 2022
@seisman seisman changed the title load_earth_relief: Move parameter use_srtm below data_source load_earth_relief: Move parameter use_srtm after data_source Dec 7, 2022
@seisman seisman merged commit db92a8d into main Dec 7, 2022
@seisman seisman deleted the earth-relief-doc-update-srtm-position branch December 7, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants