Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'argument' by 'parameter' in 'contour_map.py' and 'lines.py' #2077

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

yvonnefroehlich
Copy link
Member

Description of proposed changes

Related to the decision in issue #886 this PR aims to update the tutorial Creating a map with contour lines to use 'parameter' instead of 'argument'.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14
Copy link
Member

weiji14 commented Aug 22, 2022

Thanks @yvonnefroehlich, could you please also change 'argument' -> 'parameter' in:

# additional line. Arguments such as ``region``, ``projection``, and ``frame``

@yvonnefroehlich
Copy link
Member Author

Thanks @yvonnefroehlich, could you please also change 'argument' -> 'parameter' in:

# additional line. Arguments such as ``region``, ``projection``, and ``frame``

Thanks @weiji14! Done in a7b8e89.

@yvonnefroehlich yvonnefroehlich changed the title Replace 'argument' by 'parameter' in 'contour_map.py' Replace 'argument' by 'parameter' in 'contour_map.py' and 'lines.py' Aug 22, 2022
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@weiji14 weiji14 added documentation Improvements or additions to documentation final review call This PR requires final review and approval from a second reviewer skip-changelog Skip adding Pull Request to changelog labels Aug 22, 2022
@seisman seisman added this to the 0.8.0 milestone Aug 22, 2022
@seisman seisman merged commit 817b28a into main Aug 22, 2022
@seisman seisman deleted the update-contourmap-parameter branch August 22, 2022 14:04
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants