Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing arguments containing spaces into pygmt functions #1487

Merged
merged 23 commits into from
Mar 13, 2022

Commits on Sep 7, 2021

  1. Replace spaces in arguments with octal code 040

    Modifying build_arg_string function to replace blank space
    characters with octal code 040, and added a doctest to
    check various combinations with single and double quotes
    included.
    weiji14 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    b5ad405 View commit details
    Browse the repository at this point in the history
  2. Remove workarounds for spaces in fig.subplot's autolabel and title args

    Supersedes workaround for subplot's autolabel (-A)
    and title (-T) parameters in
    a9d167d,
    4126c16, and
    eadb847.
    weiji14 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    14648c2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    924f439 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    707745f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    03e4308 View commit details
    Browse the repository at this point in the history
  6. Remove workaround for spaces in fig.psconvert prefix

    Doesn't work yet, as the filename will contain the 040 octal
    code, but committing to have the diff available for review.
    weiji14 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    095449a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d81b80b View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. Configuration menu
    Copy the full SHA
    dd849cb View commit details
    Browse the repository at this point in the history
  2. Ensure spaces in pygmt.config arguments can work

    Also added a regression test for
    FORMAT_DATE_MAP="o dd".
    weiji14 committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    c29e632 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Manually handle prefix -F in psconvert

    So that fig.savefig won't insert `\040` characters when saving filenames with spaces. Resolves problem mentioned in https://github.com/GenericMappingTools/pygmt/pull/1487/files#r703116544
    weiji14 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    83c8c3b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2ba8420 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2022

  1. Configuration menu
    Copy the full SHA
    b58af8b View commit details
    Browse the repository at this point in the history
  2. Handle PROJ4 strings with spaces

    Instead of converting spaces to \040 in proj4 strings, just remove them directly. Added parametrized unit tests to basemap and grdproject to check that it works.
    weiji14 committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    3ec7727 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f19c41b View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. Configuration menu
    Copy the full SHA
    7a518a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9774d5e View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. Refactor the whole function using a single loop

    Co-Authored-By: Dongdong Tian <[email protected]>
    weiji14 and seisman committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    ff40d27 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    36fdec5 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Configuration menu
    Copy the full SHA
    6c399ba View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2022

  1. Configuration menu
    Copy the full SHA
    4770396 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2022

  1. Configuration menu
    Copy the full SHA
    801ba01 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ecb580e View commit details
    Browse the repository at this point in the history
  3. Fix rst syntax in pygmt/helpers/utils.py

    Co-Authored-By: Dongdong Tian <[email protected]>
    weiji14 and seisman committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    a526d45 View commit details
    Browse the repository at this point in the history