Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog entry for v0.4.1 #1414

Merged
merged 18 commits into from
Aug 7, 2021
Merged

Changelog entry for v0.4.1 #1414

merged 18 commits into from
Aug 7, 2021

Conversation

core-man
Copy link
Member

@core-man core-man commented Aug 5, 2021

Description of proposed changes

This PR is a draft changelog entry for v0.4.1.

Preview: https://pygmt-git-changelog-release-gmt.vercel.app/changes.html#changelog

Previous release at #1341

Changelog made by following the instructions at https://github.com/GenericMappingTools/pygmt/blob/main/doc/maintenance.md#updating-the-changelog

TODO:

Relates to #1402

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

doc/changes.md Show resolved Hide resolved
README.rst Show resolved Hide resolved
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just some comments, mostly on the highlight items.

README.rst Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Show resolved Hide resolved
doc/changes.md Outdated
Comment on lines 45 to 48
* [@sean0921](https://github.com/sean0921)
* [Soham Banerjee](https://github.com/soham4abc)
* [Jiayuan Yao](https://github.com/core-man)
* [@yohaimagen](https://github.com/yohaimagen)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @sean0921 and @yohaimagen to see if they would like their full name in the list. If not we can just go by their GitHub username.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to use my full name please, Yohai Magen, thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to use my full name please, Yohai Magen, thanks!

Thanks. Done in 5578ece.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being late. Just change my full name to Sean Li-Shin Ho for documents in main branch, or I can make a PR for this if needed. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've edited in your full name at https://github.com/GenericMappingTools/pygmt/releases/tag/v0.4.1. Feel free to open a PR to change things in https://github.com/GenericMappingTools/pygmt/blob/v0.4.1/doc/changes.md#contributors (you're also welcome to add your name to AUTHORS.md if you're keen on contributing more in the future.

doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
@weiji14 weiji14 added the skip-changelog Skip adding Pull Request to changelog label Aug 6, 2021
@weiji14 weiji14 added this to In progress in Release v0.4.x via automation Aug 6, 2021
@weiji14 weiji14 added this to the 0.4.1 milestone Aug 6, 2021
README.rst Outdated Show resolved Hide resolved
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after merging #1415.

Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge after #1415 is done!

README.rst Show resolved Hide resolved
doc/changes.md Show resolved Hide resolved
doc/changes.md Outdated Show resolved Hide resolved
doc/changes.md Show resolved Hide resolved
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good to me aside from one minor typo... Do we want to wait a bit longer, or merge this in and get on with tagging the release? If no objections I'll merge this in <1 hour at UTC 11:00?

doc/changes.md Outdated Show resolved Hide resolved
Co-authored-by: Wei Ji <[email protected]>
@core-man
Copy link
Member Author

core-man commented Aug 7, 2021

Ok, looks good to me aside from one minor typo... Do we want to wait a bit longer, or merge this in and get on with tagging the release?

Maybe we could still wait for about a few hours to see if Will is okay?

@weiji14
Copy link
Member

weiji14 commented Aug 7, 2021

Ok, looks good to me aside from one minor typo... Do we want to wait a bit longer, or merge this in and get on with tagging the release?

Maybe we could still wait for about a few hours to see if Will is okay?

Sounds good. Just want to make the 7 Aug 2021 deadline (specifically before it turns 8 Aug at UTC).

Copy link
Contributor

@willschlitzer willschlitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@core-man
Copy link
Member Author

core-man commented Aug 7, 2021

Ok, looks good to me aside from one minor typo... Do we want to wait a bit longer, or merge this in and get on with tagging the release?

Maybe we could still wait for about a few hours to see if Will is okay?

Sounds good. Just want to make the 7 Aug 2021 deadline (specifically before it turns 8 Aug at UTC).

Let's do it now~~

@weiji14 weiji14 merged commit 31980e8 into main Aug 7, 2021
@weiji14 weiji14 deleted the changelog-release branch August 7, 2021 10:46
Release v0.4.x automation moved this from In progress to Done Aug 7, 2021
@core-man core-man mentioned this pull request Aug 7, 2021
23 tasks
@willschlitzer willschlitzer mentioned this pull request Oct 29, 2021
12 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
* Add changelog entry for v0.4.1
* Add team page to highlight
* Add change from master to main to highlight
* Add Yohai Magen to citation

Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Michael Grund <[email protected]>
@weiji14 weiji14 mentioned this pull request Sep 1, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip adding Pull Request to changelog
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

7 participants