Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify header sizes in style.css and remove bold formatting from contributing.md headers #1385

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

maxrjones
Copy link
Member

Description of proposed changes
This PR specifies the header styles in style.css based on the comments in #1339 (comment) and #1335 (review) that header 4 levels are too small. The header sizes decrease linearly from 200% for header 1.

For explanation, in #1335 I suggested that this was a MyST issue, but in testing a new issue for conversion from .md to .rst I discovered that the ReST versus Markdown format did not affect the header appearance, hence the fix in style.css and the removal of the temporary fix in bolding the headers in contributing.md.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@maxrjones maxrjones added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Jul 15, 2021
@maxrjones maxrjones self-assigned this Jul 15, 2021
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better! I'd wait for a second (or second) opinion/approval before merging directly, preferably someone on a different browser (mine is Firefox).

doc/_static/style.css Outdated Show resolved Hide resolved
Copy link
Member

@core-man core-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on Chrome on a 22-inch display and Safari on a 13 inch one~

Copy link
Contributor

@willschlitzer willschlitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (Ubuntu, Firefox, 21 inch monitor)

@willschlitzer willschlitzer added the final review call This PR requires final review and approval from a second reviewer label Jul 16, 2021
@maxrjones maxrjones merged commit 9efe317 into master Jul 16, 2021
@maxrjones maxrjones deleted the header-style branch July 16, 2021 18:00
@maxrjones maxrjones removed the final review call This PR requires final review and approval from a second reviewer label Jul 16, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants