-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap nearneighbor #1379
Merged
weiji14
merged 29 commits into
GenericMappingTools:main
from
JamieJQuinn:feature/implement-nearneighbour
Sep 23, 2021
Merged
Wrap nearneighbor #1379
weiji14
merged 29 commits into
GenericMappingTools:main
from
JamieJQuinn:feature/implement-nearneighbour
Sep 23, 2021
Commits on Jul 8, 2021
-
Add implementation of nearneighbor
The implementation mirrors that of the already implemented surface. The documentation has been cobbled together from similar portions in surface and from the [official GMT documentation on nearneighbor](https://docs.generic-mapping-tools.org/latest/nearneighbor.html). Additional long-form flags have been added, reflecting the flags particularly useful for nearneighbor, mainly `-Ssearch_radius`, `-Eempty` and `-Nsectors`. Tests have been blatently copied from those testing surface, since the two functions should operate broadly similarly.
Configuration menu - View commit details
-
Copy full SHA for 3777b07 - Browse repository at this point
Copy the full SHA 3777b07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ef1683 - Browse repository at this point
Copy the full SHA 0ef1683View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fccc07 - Browse repository at this point
Copy the full SHA 1fccc07View commit details
Commits on Jul 13, 2021
-
Apply suggestions from code review
There are many pieces of older code mirroring those found in the implementation of `surface`. These have since been updating in other parts of pyGMT. Most of the review suggestions modernise this PR. Co-authored-by: Wei Ji <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 91c1707 - Browse repository at this point
Copy the full SHA 91c1707View commit details
Commits on Jul 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 51fa503 - Browse repository at this point
Copy the full SHA 51fa503View commit details
Commits on Aug 4, 2021
-
Update pygmt/src/nearneighbor.py
Enhance nearneighbour documentation Co-authored-by: Wei Ji <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0fbc83a - Browse repository at this point
Copy the full SHA 0fbc83aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ae19cb - Browse repository at this point
Copy the full SHA 4ae19cbView commit details
Commits on Sep 8, 2021
-
Co-authored-by: Wei Ji <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cedcda2 - Browse repository at this point
Copy the full SHA cedcda2View commit details -
Co-authored-by: Wei Ji <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a4bb96e - Browse repository at this point
Copy the full SHA a4bb96eView commit details -
Co-authored-by: Wei Ji <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fc43c85 - Browse repository at this point
Copy the full SHA fc43c85View commit details -
Update pygmt/src/nearneighbor.py
Co-authored-by: Wei Ji <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 57aba71 - Browse repository at this point
Copy the full SHA 57aba71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 620e99a - Browse repository at this point
Copy the full SHA 620e99aView commit details
Commits on Sep 15, 2021
-
Apply suggestions from code review
Co-authored-by: Meghan Jones <[email protected]> Co-authored-by: Michael Grund <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 62d4522 - Browse repository at this point
Copy the full SHA 62d4522View commit details -
Configuration menu - View commit details
-
Copy full SHA for e09981f - Browse repository at this point
Copy the full SHA e09981fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c22ebb0 - Browse repository at this point
Copy the full SHA c22ebb0View commit details
Commits on Sep 16, 2021
-
Set incols (i) to use sequence_comma
Co-Authored-By: Dongdong Tian <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 38cb0f7 - Browse repository at this point
Copy the full SHA 38cb0f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcdf379 - Browse repository at this point
Copy the full SHA dcdf379View commit details -
Configuration menu - View commit details
-
Copy full SHA for d09d63d - Browse repository at this point
Copy the full SHA d09d63dView commit details
Commits on Sep 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3e33f3a - Browse repository at this point
Copy the full SHA 3e33f3aView commit details
Commits on Sep 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b7fb6a9 - Browse repository at this point
Copy the full SHA b7fb6a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6118d23 - Browse repository at this point
Copy the full SHA 6118d23View commit details -
Configuration menu - View commit details
-
Copy full SHA for f344cf5 - Browse repository at this point
Copy the full SHA f344cf5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b187b4c - Browse repository at this point
Copy the full SHA b187b4cView commit details -
Apply suggestions from code review
Co-Authored-By: Dongdong Tian <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a0da121 - Browse repository at this point
Copy the full SHA a0da121View commit details -
Merge two tests using pytest parametrize
Check that numpy.array and xarray.Dataset inputs work.
Configuration menu - View commit details
-
Copy full SHA for 3349396 - Browse repository at this point
Copy the full SHA 3349396View commit details
Commits on Sep 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 758e8bb - Browse repository at this point
Copy the full SHA 758e8bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 523e5ec - Browse repository at this point
Copy the full SHA 523e5ecView commit details
Commits on Sep 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 281c49d - Browse repository at this point
Copy the full SHA 281c49dView commit details -
Co-Authored-By: Dongdong Tian <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3857cf9 - Browse repository at this point
Copy the full SHA 3857cf9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.