Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap nearneighbor #1379

Merged
merged 29 commits into from
Sep 23, 2021
Merged

Wrap nearneighbor #1379

merged 29 commits into from
Sep 23, 2021

Commits on Jul 8, 2021

  1. Add implementation of nearneighbor 

    The implementation mirrors that of the already implemented surface.

The documentation has been cobbled together from similar portions in
surface and from the [official GMT documentation on
nearneighbor](https://docs.generic-mapping-tools.org/latest/nearneighbor.html).
Additional long-form flags have been added, reflecting the flags
particularly useful for nearneighbor, mainly `-Ssearch_radius`,
`-Eempty` and `-Nsectors`.

Tests have been blatently copied from those testing surface, since the
two functions should operate broadly similarly.
    @JamieJQuinn
    JamieJQuinn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    3777b07 View commit details
    Browse the repository at this point in the history

  2. Improve formatting

    @JamieJQuinn
    JamieJQuinn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    0ef1683 View commit details
    Browse the repository at this point in the history

  3. Add nearneighbor to API index

    @JamieJQuinn
    JamieJQuinn committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    1fccc07 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Apply suggestions from code review 

    There are many pieces of older code mirroring those found in the implementation of `surface`. These have since been updating in other parts of pyGMT. Most of the review suggestions modernise this PR.

Co-authored-by: Wei Ji <[email protected]>
    @JamieJQuinn @weiji14
    JamieJQuinn and weiji14 committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    91c1707 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. Fix unused import

    @JamieJQuinn
    JamieJQuinn committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    51fa503 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2021

  1. Update pygmt/src/nearneighbor.py 

    Enhance nearneighbour documentation

Co-authored-by: Wei Ji <[email protected]>
    @JamieJQuinn @weiji14
    JamieJQuinn and weiji14 committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    0fbc83a View commit details
    Browse the repository at this point in the history

  2. Add similar figure to that found in GMTs nearneighbor documentation

    @JamieJQuinn
    JamieJQuinn committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    4ae19cb View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Don't use which in test 

    Co-authored-by: Wei Ji <[email protected]>
    @JamieJQuinn @weiji14
    JamieJQuinn and weiji14 committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    cedcda2 View commit details
    Browse the repository at this point in the history

  2. Name test more appropriately 

    Co-authored-by: Wei Ji <[email protected]>
    @JamieJQuinn @weiji14
    JamieJQuinn and weiji14 committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    a4bb96e View commit details
    Browse the repository at this point in the history

  3. Add newer common options 

    Co-authored-by: Wei Ji <[email protected]>
    @JamieJQuinn @weiji14
    JamieJQuinn and weiji14 committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    fc43c85 View commit details
    Browse the repository at this point in the history

  4. Update pygmt/src/nearneighbor.py 

    Co-authored-by: Wei Ji <[email protected]>
    @JamieJQuinn @weiji14
    JamieJQuinn and weiji14 committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    57aba71 View commit details
    Browse the repository at this point in the history

  5. Remove unused import

    @JamieJQuinn
    JamieJQuinn committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    620e99a View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Michael Grund <[email protected]>
    @weiji14 @maxrjones @michaelgrund
    3 people committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    62d4522 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/implement-nearneighbour

    @weiji14
    weiji14 committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    e09981f View commit details
    Browse the repository at this point in the history

  3. Fix lint errors

    @weiji14
    weiji14 committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    c22ebb0 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. Set incols (i) to use sequence_comma 

    Co-Authored-By: Dongdong Tian <[email protected]>
    @weiji14 @seisman
    weiji14 and seisman committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    38cb0f7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/implement-nearneighbour

    @weiji14
    weiji14 committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    dcdf379 View commit details
    Browse the repository at this point in the history

  3. Remove test_nearneighbor_input_xy_no_z 

    Following GenericMappingTools#1478.
    @weiji14
    weiji14 committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    d09d63d View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. Ignore flake8 error using noqa W505

    @weiji14
    weiji14 committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    3e33f3a View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2021

  1. Merge branch 'main' into feature/implement-nearneighbour

    @weiji14
    weiji14 committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    b7fb6a9 View commit details
    Browse the repository at this point in the history

  2. Fix incorrect indentation

    @weiji14
    weiji14 committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    6118d23 View commit details
    Browse the repository at this point in the history

  3. Shorten line length to under 100 using the dev image

    @weiji14
    weiji14 committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    f344cf5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feature/implement-nearneighbour

    @weiji14
    weiji14 committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    b187b4c View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-Authored-By: Dongdong Tian <[email protected]>
    @weiji14 @seisman
    weiji14 and seisman committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    a0da121 View commit details
    Browse the repository at this point in the history

  6. Merge two tests using pytest parametrize 

    Check that numpy.array and xarray.Dataset inputs work.
    @weiji14
    weiji14 committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    3349396 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. Merge branch 'main' into feature/implement-nearneighbour

    @weiji14
    weiji14 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    758e8bb View commit details
    Browse the repository at this point in the history

  2. Remove unused GMTInvalidInput import

    @weiji14
    weiji14 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    523e5ec View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Merge branch 'main' into feature/implement-nearneighbour

    @weiji14
    weiji14 committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    281c49d View commit details
    Browse the repository at this point in the history

  2. Typo fixes 

    Co-Authored-By: Dongdong Tian <[email protected]>
    @weiji14 @seisman
    weiji14 and seisman committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    3857cf9 View commit details
    Browse the repository at this point in the history