Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let Figure.savefig support filenames with spaces #1116

Merged
merged 9 commits into from
Jun 14, 2021
Merged

Let Figure.savefig support filenames with spaces #1116

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
551b824
Let Figure.savefig support filenames with spaces
seisman Mar 24, 2021
a29b259
Merge branch 'master' into filename-with-spaces
seisman Mar 24, 2021
abaee2e
Update pygmt/figure.py
seisman Mar 25, 2021
e7d4923
Merge branch 'master' into filename-with-spaces
seisman Apr 1, 2021
6a170cd
Merge branch 'master' into filename-with-spaces
seisman May 9, 2021
9f4314f
Merge branch 'master' into filename-with-spaces
seisman May 12, 2021
4d86e78
Rewrite the test using GMTTempFile
seisman May 12, 2021
e1d2870
Merge branch 'master' into filename-with-spaces
seisman Jun 10, 2021
9f081ff
Merge branch 'master' into filename-with-spaces
seisman Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rewrite the test using GMTTempFile
  • Loading branch information
@seisman
seisman committed May 12, 2021
commit 4d86e7816cce4b6cf297278e56f20228ab976c4e
8 changes: 4 additions & 4 deletions pygmt/tests/test_figure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import pytest
from pygmt import Figure, set_display
from pygmt.exceptions import GMTInvalidInput
from pygmt.helpers import GMTTempFile


def test_figure_region():
Expand Down Expand Up @@ -102,10 +103,9 @@ def test_figure_savefig_filename_with_spaces():
"""
fig = Figure()
fig.basemap(region=[0, 1, 0, 1], projection="X1c/1c", frame=True)
fname = "test_figure_savefig filename with spaces.png"
fig.savefig(fname)
assert os.path.exists(fname)
os.remove(fname)
with GMTTempFile(prefix="pygmt-filename with spaces", suffix=".png") as imgfile:
fig.savefig(imgfile.name)
assert os.path.exists(imgfile.name)


def test_figure_savefig():
Expand Down