-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Figure.meca() to better determine the data format code #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ping @tjnewton @liamtoney for review as you wrote the initial |
Good idea. I like your changes. |
liamtoney
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
seisman
added
maintenance
Boring but important stuff for the core devs
skip-changelog
Skip adding Pull Request to changelog
labels
Mar 4, 2021
seisman
changed the title
Refactor Figure.meca() to make the codes more readable and reusable
Refactor Figure.meca() to better determine the data format code
Mar 4, 2021
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
maintenance
Boring but important stuff for the core devs
skip-changelog
Skip adding Pull Request to changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The
Figure.meca()
method is too complicated to read and maintain, and also has the lowest code coverage (~75%).I will try to refactor the method, but in separate PRs. Otherwise the changes would be too big to review.
This PR is the first step to refactor the codes. The old code uses nested if-else-statement to determine the data format (meca -S option) from parameters
convention
andcomponent
.The new code uses two dicts instead, and also wrap the code in a separate function
data_format_code
, because the function will also be used inFigure.coupe()
(not wrapped yet).I also add several doctests to check the function and increase the code coverage.
References: https://docs.generic-mapping-tools.org/latest/supplements/seis/meca.html#s
Fixes #
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version