Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_load_remote_dataset: Rename parameter names and remove trailing underscore from prefix #3202

Merged
merged 3 commits into from
Apr 27, 2024
Merged

_load_remote_dataset: Rename parameter names and remove trailing underscore from prefix #3202

merged 3 commits into from
Apr 27, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 26, 2024 •
edited
Loading

  • Rename dataset_name to name
  • Rename dataset_prefix to prefix
  • Remove the trailing _ from dataset_prefix, e.g., dataset_prefix="earth_relief_" should be prefix="earth_relief".

Closes #3190.

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. labels Apr 26, 2024
@seisman seisman added this to the 0.12.0 milestone Apr 26, 2024
@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Apr 26, 2024
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 27, 2024
@seisman seisman merged commit e4a4285 into main Apr 27, 2024
20 of 21 checks passed
@seisman seisman deleted the load_remote_datasets branch April 27, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelgrund michaelgrund michaelgrund approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

_load_remote_dataset: Rename the parameter names 'dataset_name'/'dataset_prefix' to 'name'/'prefix'
2 participants
@seisman @michaelgrund