Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_load_remote_dataset: Rename the parameter names 'dataset_name'/'dataset_prefix' to 'name'/'prefix' #3190

Closed
seisman opened this issue Apr 22, 2024 · 1 comment · Fixed by #3202
Closed

_load_remote_dataset: Rename the parameter names 'dataset_name'/'dataset_prefix' to 'name'/'prefix' #3190

seisman opened this issue Apr 22, 2024 · 1 comment · Fixed by #3202
Labels
maintenance Boring but important stuff for the core devs
Milestone
0.12.0

Comments

@seisman
Copy link
Member

seisman commented Apr 22, 2024

In the _load_remote_dataset function, we have parameters dataset_name and dataset_prefix. I propose to

  • Rename dataset_name to name
  • Rename dataset_prefix to prefix
  • Remove the trailing _ from dataset_prefix, e.g., dataset_prefix="earth_relief_" should be prefix="earth_relief".

Originally posted by @seisman in #3120 (comment)
@seisman seisman mentioned this issue Apr 22, 2024
Merged
@seisman
Copy link
Member Author

seisman commented Apr 22, 2024

Need to wait for #3120 and #3048.

@seisman seisman added the discussions Need more discussion before taking further actions label Apr 22, 2024
@seisman seisman mentioned this issue Apr 26, 2024
Merged
@seisman seisman added this to the 0.12.0 milestone Apr 26, 2024
@seisman seisman added maintenance Boring but important stuff for the core devs and removed discussions Need more discussion before taking further actions labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Milestone
0.12.0
1 participant
@seisman