Fix glitches when converting some scripts to modern mode #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all scripts are meant to be exposed to the users via documentation and may not be simple to reproduce in modern mode. I have fixed some fo the changes, with more to come leter.
joa-quim
approved these changes
Sep 28, 2018
joa-quim
approved these changes
Sep 28, 2018
obaney
pushed a commit
to obaney/gmt
that referenced
this pull request
Aug 18, 2021
This was recently introduced to the GMT API to deal with grd modules that required padded grids.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all scripts are meant to be exposed to the users via documentation and may not be simple to reproduce in modern mode. I have fixed some fo the changes, with more to come later.
We have two types of scripts in the doc_modern/scripts folder:
The recent conversion to modern mode exposed a few issues in modern mode that I need to examine (for instance, mapproject needs to obtain -R if not given, but not always). Also, it may not make sense to try to rewrite complicated, awk-stricken classic scripts making just a figure to a modern mode script. I will examine which ones should be reverted (or not).
As for scripts under doc_modern/examples we should strive to make those modern. Note that some of them also appear under test/exmod for now.