Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add nightly packaging to CI #936

Closed
wants to merge 7 commits into from
Closed

WIP: Add nightly packaging to CI #936

wants to merge 7 commits into from

Conversation

seisman
Copy link
Member

@seisman seisman commented Jun 15, 2019

Description of proposed changes

This PR makes source packages and installer nightly, to test if changing CMakeLists.txt breaks packaging.

  • Linux: Make source packages only
  • macOS: Make both source packages and Bundles
  • Windows: Make both source packages and binary installers

This also make it possible to distribute nightly built installers for macOS and Windows.

@seisman seisman changed the title Add nightly packaging to CI WIP: Add nightly packaging to CI Jun 15, 2019
@joa-quim
Copy link
Member

Cool. But I'm sure we'll still have to tune the Win installer section. For example, in my ConfigUser.cmake I have

	# CPACK doesn't copy the omp dll probably becuase it uses the loadlibrary dynamic linking tech
	if (BITAGE EQUAL 64)
		if (VC STREQUAL "VC12")
			set (OMP_DLL_LOC "C:/Program Files (x86)/Microsoft Visual Studio 12.0/VC/redist/x64/Microsoft.VC120.OPENMP/vcomp120.dll")
		else ()
			set (OMP_DLL_LOC "C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Redist/MSVC/14.16.27012/x64/Microsoft.VC141.OPENMP/vcomp140.dll")
		endif ()
	else (BITAGE EQUAL 64)
		if (VC STREQUAL "VC12")
			set (OMP_DLL_LOC "C:/Program Files (x86)/Microsoft Visual Studio 12.0/VC/redist/x86/Microsoft.VC120.OPENMP/vcomp120.dll")
		else ()
			set (OMP_DLL_LOC "C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Redist/MSVC/14.16.27012/x86/Microsoft.VC141.OPENMP/vcomp140.dll")
		endif ()
	endif (BITAGE EQUAL 64)

as well as other sections to copy the GDAL_DATA and PROJ_LIB directories so that GDAL will work without users even knowing that we set up the ENV vars under the hood. But this is for GDAL3 and Vcpkg is still on GDAL2.4.1.

Ah, and there is also the issue of the gmtmex that can't be built by the CI script. If there is a way of it fetching the mex file (a dll) from somewhere we could think of a solution for this.

@seisman
Copy link
Member Author

seisman commented Jun 15, 2019

Yes, we definitely need tune the cmake files if we want a nightly release. We can do it after the beta release.

@seisman seisman force-pushed the ci-packaging branch 2 times, most recently from 77251bc to 17468cf Compare June 16, 2019 04:26
@seisman seisman closed this Jun 17, 2019
@seisman seisman deleted the ci-packaging branch June 17, 2019 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants