Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Set GMT_BUILD_DATE to the current date or the last commit date #8501

Merged
merged 1 commit into from
May 31, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented May 31, 2024

When building the GMT release tarball (not a git repository), I see an error like:

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

The error was introduced in #7468, because for release tarballs, there is no .git directory, so git log command doesn't work.

This PR fixes the issue by setting the GMT_BUILD_DATE to the current UTC date by default, and only use the last commit date if it's a git repository.

Patches #7468.

@seisman seisman added the bug Something isn't working label May 31, 2024
@seisman seisman added this to the 6.6.0 milestone May 31, 2024
@seisman seisman requested a review from joa-quim May 31, 2024 07:55
@seisman seisman merged commit 5e53ea3 into master May 31, 2024
15 checks passed
@seisman seisman deleted the fix/build-date branch May 31, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants