Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos when parsing -h option #8477

Merged
merged 2 commits into from
May 6, 2024
Merged

Fix typos when parsing -h option #8477

merged 2 commits into from
May 6, 2024

Conversation

joa-quim
Copy link
Member

@joa-quim joa-quim commented May 6, 2024

Note that inside the parse_h_option function it was setting the variables for opt_g

@joa-quim joa-quim requested a review from seisman May 6, 2024 18:43
@seisman seisman changed the title These must be a bug that had not been found yet. Fix typos when parsing -h option May 6, 2024
seisman
seisman approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've updated the PR title to make it more clear what this PR does.

@joa-quim joa-quim merged commit 8704253 into master May 6, 2024
15 of 18 checks passed
@joa-quim joa-quim deleted the fix-opt_h-must-be-bug branch May 6, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seisman seisman seisman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joa-quim @seisman