Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update the SCM-check workflow #8466

Merged
merged 1 commit into from
Apr 30, 2024
Merged

CI: Update the SCM-check workflow #8466

merged 1 commit into from
Apr 30, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 30, 2024

Description of proposed changes

Fixes #

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@seisman seisman force-pushed the ci/scm-check branch 2 times, most recently from 1798136 to 0802255 Compare April 30, 2024 01:33
@seisman seisman marked this pull request as ready for review April 30, 2024 01:36
@seisman seisman requested a review from joa-quim April 30, 2024 01:36
@joa-quim
Copy link
Member

Nothing against updating the workflow but honestly I don't see the interest on these frequent updates of the SCM that cause test breakings.

@seisman
Copy link
Member Author

seisman commented Apr 30, 2024

I agree. I think we should be reminded that a new SCM is available, then we can decide if we want to update the CPTs or not.

@seisman seisman merged commit 5102c4e into master Apr 30, 2024
1 check passed
@seisman seisman deleted the ci/scm-check branch April 30, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants