Free the longoptions from the #ifdefs jail #8441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joa-quim
changed the title
|
Just to clarify, longoptification of the core modules is complete. Many
supplemental modules remain undone.
Ron
… Ron Davis has finish the implementation and he is no longer contributing,
so do not let the longoptions code rotten under the #ifdefs curtain.
Nothing that I detected is broken by this release. What, and that is a big
WHAT, is left to do is to document their use.
You can view, comment on, or merge this pull request online at:
#8441
-- Commit Summary --
* Free the longotions from the #ifdefs jail
-- File Changes --
M src/gmt_init.c (33)
-- Patch Links --
https://github.com/GenericMappingTools/gmt/pull/8441.patch
https://github.com/GenericMappingTools/gmt/pull/8441.diff
--
Reply to this email directly or view it on GitHub:
#8441
You are receiving this because your review was requested.
Message ID: ***@***.***>
|
|
Thanks Roger. Still better advance with what we already have. |
|
also need to remove it from cmake settings |
|
Done. |
seisman
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roger Davis has finish the implementation and he is no longer contributing, so do not let the longoptions code rotten under the #ifdefs curtain. Nothing that I detected is broken by this release. What, and that is a big WHAT, is left to do is to document their use.