Address issues raised in #8438 and more. #8440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
grdimage -Aworked but with many limitations. For example it didn't set the CRS in the output GeoTIFF file. Also, if using a EPSG or proj4 string had many hidden errors. The problem is that using-J+proj=...opens the door to awful complicated code flows. This PR fixes several of those issues, but not all. For example, this now works correctlyor
or
but this hangs when it fall ins a nearly infinite loop due to badly assigned scales.
Spend 2 day debugging/relearning things but must stop here for now. Again, this PR hopefully fixes many issues, but not all.