Patch a case where nodes with very close to zero values created an infinite alloc loop. #8388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…finite alloc loop. The situation arose when the condition if ((dz = z[this_side] - z[this_side+1]) == 0.0f) continue; was never met by a tiny bit. Comparing to 0.0 is never a good idea. So I made it if (fabs((dz = z[this_side] - z[this_side+1])) < 1e-10) continue; I get 6 grdcontour test failures but they don't seem related to this change (more due to the endless headache of slight different grids). Fixes #8387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The situation arose when the condition
if ((dz = z[this_side] - z[this_side+1]) == 0.0f) continue;
was never met by a tiny bit. Comparing to 0.0 is never a good idea. So I made it
if (fabs((dz = z[this_side] - z[this_side+1])) < 1e-10) continue;
I get 6 grdcontour test failures but they don't seem related to this change (more due to the endless headache of slight different grids).
Fixes #8387
Fixes #6738