Add longoptions support for psconvert. #8309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulWessel
approved these changes
Jan 18, 2024
- Changed -A from "adjust|crop" to more appropriate "autocrop|crop" - Added "ghost_*" to align with "ghost_path" - Replaced "bb_style" with "show_bbox" - Added "ps_layer" as alternative to "pslayer"
|
@remkos, make sure you dont remove aliases that the python and Julia folks have put in since they are needed. |
You're right. Checked that for -N but forgot to do so for -A. I just restored --adjust |
|
Also restored the Python -N bb_style string removed by yesterday's changes. |
joa-quim
reviewed
Jan 28, 2024
src/longopt/psconvert_inc.h
Outdated
| GMT_TP_STANDARD }, | ||
| { 0, 'Z', "", | ||
| "", "", | ||
| { 0, 'W', "esri|world_file", |
There was a problem hiding this comment.
I don't see the need to add esri, which is the name of the company. world_file is like GDAL refers to it for example.
src/longopt/psconvert_inc.h
Outdated
| "", "", | ||
| GMT_TP_STANDARD }, | ||
| { 0, 'N', "", | ||
| "", "", | ||
| { 0, 'N', "bb_style|show_bbox", |
There was a problem hiding this comment.
I prefer bgcolor. This is mainly not about the BoundingBox per se but specially on the possibility to paint the BB area.
|
Applied suggested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Python differences:
No differences.
Julia differences:
Replaced -I icc_gray (???) with python resize.
Julia does not have -N
Some other aliases added on top of Julia.
Fixes #
Reminders