Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require movie canvas dimensions in integer pixels when using modifiers +c|i #8297

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

PaulWessel
Copy link
Member

If plot dimensions are given in pixels instead of cm, inches etc then use +c|i to indicate that units the dpu is in since actual plot dimensions is then the pixel dimensions divided by the dpu which gives either cm or inches. This feature was implemented to avoid having to write painful things like

-C16.5517241379cx6.03448275862cx116

Much cleaner to allow

-C1920x700x116+c

This is helpful when it is simpler to specify the dimensions in integers but we will need to relate those via the dpc to physical dimensions (here 16.5517241379c).

If plot dimensions are given in pixels instead of cm, inches etc then use +c|i to indicate that units the dpu is in since actual plot dimensions is then the pixel dimensions divided by the dpu which gives either cm or inches.
@PaulWessel PaulWessel added the enhancement Improving an existing feature label Jan 16, 2024
@PaulWessel PaulWessel added this to the 6.6.0 milestone Jan 16, 2024
@PaulWessel PaulWessel self-assigned this Jan 16, 2024
@Esteban82
Copy link
Member

Do you any script to test it?

@PaulWessel
Copy link
Member Author

Not a new one but my movie in the paper now uses this and it works.

Copy link
Member

@Esteban82 Esteban82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blind approve

@PaulWessel PaulWessel merged commit a2cc356 into master Jan 16, 2024
6 checks passed
@PaulWessel PaulWessel deleted the movie-dimensions branch January 16, 2024 17:07
@Esteban82 Esteban82 added the add-changelog Add PR to the changelog label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-changelog Add PR to the changelog enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants