Maintenance PR only for better function name #8288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Se have functions like gmt_get_required_sint and gmt_get_required_uint, but we did not have one for signed int64_t and we never use "s" as a prefix anyway. So this PR simply removes the sint and calls in int, and adde int64_t to match the uint64_t function. No effect on anything except ensuring we have the various flavors as needed.
seisman
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se have functions like gmt_get_required_sint and gmt_get_required_uint, but we did not have one for signed int64_t and we never use "s" as a prefix anyway; there is only u or no u up front.. So this PR simply removes the sint and calls it int, and adds int64_t to match the uint64_t function. No effect on anything except ensuring we have the various flavours as needed.