Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colorbar: Add modifier +n|N to -D option for placing colorbar NaN box on the right and to skip label #8287

Merged
merged 12 commits into from
Jan 13, 2024

Conversation

PaulWessel
Copy link
Member

The new modifier for placing a NaN-color box and NAN label at the end of the color bar is now extended to

+n|N[-|label]

where the new +N means place it on the right side of the bar (top for vertical bars) and if the label is - we do not place any label. Default is still NaN unless you append an alternative label.

Added two new test scripts psscale/colorbar-nans-h.sh and psscale/colorbar-nans-v.sh to ensure it works for both horizontal and vertical bars.

@PaulWessel PaulWessel added documentation Improve documentation enhancement Improving an existing feature labels Jan 12, 2024
@PaulWessel PaulWessel added this to the 6.6.0 milestone Jan 12, 2024
@PaulWessel PaulWessel requested a review from a team January 12, 2024 15:43
@PaulWessel PaulWessel self-assigned this Jan 12, 2024
Copy link
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added test/baseline/psscale/colorbar-nans-h.ps
added test/baseline/psscale/colorbar-nans-v.ps
modified test/baseline/psscale/

Image diff(s)

Added images

  • test/baseline/psscale/colorbar-nans-h.png

  • test/baseline/psscale/colorbar-nans-v.png

Modified images

Path Old New

Report last updated at commit a1fe9aa

@seisman
Copy link
Member

seisman commented Jan 12, 2024

Add the add-changelog label and change the PR title to a more descriptive one like "colorbar: Add modifier +n|N to -D option for placing colorbar NaN box on the right and to skip label"? If so, life will be much easier when we work on the GMT 6.6.0 changelog (xref #8159).

@PaulWessel PaulWessel added the add-changelog Add PR to the changelog label Jan 12, 2024
@PaulWessel PaulWessel changed the title Add modifier for placing colorbar NaN box on the right and to skip label colorbar: Add modifier +n|N to -D option for placing colorbar NaN box on the right and to skip label Jan 12, 2024
@PaulWessel PaulWessel merged commit 15de3e3 into master Jan 13, 2024
7 checks passed
@PaulWessel PaulWessel deleted the nan-color-ctrl branch January 13, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-changelog Add PR to the changelog documentation Improve documentation enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants