Fix wrong calculation of median and q95 in gmtbinstats #8243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See forum post for background. In what appears to be a copy/paste error, the calculation taking an average (media if n is even) and quantile (weighted average if quantile is not exactly on a single value) then the index of the second array value was junk. Fixing this and of course q95 is always > median; well >= in the case we only have a sample of size 1.
joa-quim
approved these changes
Dec 29, 2023
PaulWessel
added a commit
that referenced
this pull request
Dec 29, 2023
THe bugfix in #8243 meant the plots change a big, now with correct values for median andq95, etc.
PaulWessel
added a commit
that referenced
this pull request
Dec 29, 2023
THe bugfix in #8243 meant the plots change a big, now with correct values for median andq95, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See forum post for background on gmtbinstat problem (bug). In what appears to be a copy/paste error, the calculation taking an average (media if n is even) and quantile (weighted average if quantile is not exactly on a single value) then the index of the second array value was junk. Fixing this and of course q95 is always > median; well >= in the case we only have a sample of size 1.