standardize some statistics for a sample of 1 point #8242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While things like std.dev clearly are NaN for a single point sample, the mean is defined (the value of the single point) and you can say the same of quartiles and mode. We had a mix bag here with sometime returning NaN for mean. This PR fixes this and returns NaN only for quantities that requres > 1 point. No effect on tests.
seisman
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While things like std.dev clearly are NaN for a single point sample, the mean is defined (the value of the single point) and you can say the same of quartiles and mode. We had a mix bag here with sometime returning NaN for mean. This PR fixes this and returns NaN only for quantities that requres > 1 point. No effect on tests.