More careful with Mollweide #8239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the fix yesterday handled the bad mapproject results, it caused a failiure in several Mollweide maps and image. This revised fix simply checks that if longitude (which is actually longitude relative to the central longitude) is > 180 then we set it to ±180 plus the central longitude and the same with latitude (0). No more failures.
joa-quim
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the fix yesterday (#8238) handled the bad mapproject results, it caused a failure in several Mollweide maps and images. This revised fix simply checks that if longitude (which is actually delta longitude relative to the central longitude) is > 180 then we set it to ±180 and add back the central longitude and the same with latitude (0). No more failures and the mapproject issue remains fixed as well.