Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable longoptions support for grdfft. #8199

Merged
merged 4 commits into from
Mar 2, 2024
Merged

Enable longoptions support for grdfft. #8199

merged 4 commits into from
Mar 2, 2024

Conversation

rbdavis
Copy link
Contributor

@rbdavis rbdavis commented Dec 16, 2023

Description of proposed changes

Python differences:

No Python module.

Julia differences:

Changed -E radial_power to power_spectrum. Spectrum can be x or y
as well as radial.

Fixes #

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@rbdavis rbdavis requested a review from a team December 16, 2023 17:24
@joa-quim
Copy link
Member

This PR has covers two cases: grdfft and grdedit.

And regarding grdfft, it happening again. When you replace a GMT.jl long option that is unique (the -E case) that breaks names intersection with GMT.jl. Besides that, I prefer radial_power (rare to find in other softs) to power_pectrum.

{ 0, 'A', "azimuth|azim", "", "", "", "", GMT_TP_STANDARD },
{ 0, 'C', "zcontinue|upward", "", "", "", "", GMT_TP_STANDARD },
{ 0, 'D', "differentiate|dfdz", "", "", "", "", GMT_TP_STANDARD },
{ 0, 'E', "power_spectrum",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in the other PR. This breaks with GMT.jl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has covers two cases: grdfft and grdedit.

My apologies to all, but something strange happened this morning while I was uploading the various new longopts-* branches. There was a problem with the longopts-grdedit upload, and because of this all of the subsequent uploads and PRs I did were impacted and you will be seeing a grdeit commit notice in each one. Too long to explain here in any coherent way (and in fact I do not understand exactly what's going on), but in all of these other PRs you should see only one changed file -- in the case of this PR, that's grdfft_inc.h. You should ignore the commit notices at the top of these PRs which refer to grdedit, as that was just me putting grdedit_inc.h back to its original unedited form.

@joa-quim joa-quim merged commit d458d90 into master Mar 2, 2024
2 of 6 checks passed
@joa-quim joa-quim deleted the longopts-grdfft branch March 2, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants