Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only reset the column type at level zero. #8124

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

joa-quim
Copy link
Member

@joa-quim joa-quim commented Dec 4, 2023

This doesn't affect the CLI because it will end anyway but makes a difference for externals that keep the API alive between module calls.

Fixes #8115

This doesn't affect the CLI because it will end anyway but makes a difference for externals that keep the API alive between module calls.

Fixes #8115
Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my points on #8115 first.

Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let this pass in

@PaulWessel PaulWessel merged commit 566a8dc into master Dec 4, 2023
5 of 6 checks passed
@PaulWessel PaulWessel deleted the fix-reset-by-level branch December 4, 2023 11:32
@PaulWessel
Copy link
Member

Now merged so I will add my wrapper checks for the future.

@joa-quim
Copy link
Member Author

joa-quim commented Dec 4, 2023

Ok, but remember that AFAIK all conditions applied to Julia applies to MEX too

@PaulWessel
Copy link
Member

Yes, I will just use "external" for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grdimage -I breaks frame annotations.
2 participants