Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ctest instead of make check to avoid the stalled build issue on Travis CI #801

Merged
merged 1 commit into from
May 29, 2019

Conversation

seisman
Copy link
Member

@seisman seisman commented May 29, 2019

Although cmake --build . --target check is equivalent to ctest --force-new-ctest-process -j4, the former one causes troubles on Travis, as it wont't output anything unless all tests are completed.

Copy link
Member

@joa-quim joa-quim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-j4? Aren't Travis running machine single core?

@seisman
Copy link
Member Author

seisman commented May 29, 2019

-j4? Aren't Travis running machine single core?

Travis are running on dual-core machine. From the build output, it looks like travis can run four tests parallelly.

@seisman seisman merged commit abb720c into master May 29, 2019
@seisman seisman deleted the fix-tests branch May 29, 2019 14:46
@joa-quim
Copy link
Member

So, maybe just -j which runs with all available cores, no?

@seisman
Copy link
Member Author

seisman commented May 29, 2019

No. Unlike cmake -j, ctest -j uses a single core.

@joa-quim
Copy link
Member

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants