Convert test script for segmentizing to doc plot #7967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since plot -F is a bit obscure it really benefits from illustrations. We have two tests and I have removed one of then and converted it to a tighter figure for plot.rst.
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Added imagesModified images
Report last updated at commit 3ae0935 |
|
Why does the bot report so many deleted files? Is that ok? |
|
No not good, not sure what I did, pinging @seisman for assistance |
|
Not sure what happened, maybe because @PaulWessel was working on several PRs that change DVC files at the same time. Now this PR has conflicts, which must be resolved first. |
|
Conflicts fixed. |
seisman
reviewed
Oct 25, 2023
doc/scripts/images.dvc
Outdated
| - md5: e0c1334651a2b06141769144677fdff5.dir | ||
| size: 33377667 | ||
| nfiles: 204 | ||
| - md5: 453d9a7563e7c2ec20cc0ed14716053c.dir |
There was a problem hiding this comment.
The changes doesn't make sense to me. I expect to see nfiles in doc/scripts/images.dvc increase by 1, and nfiles in test/baseline/psxy.dvc decrease by 1.
There was a problem hiding this comment.
At the top, Paul said that he removed one test.
|
Hi @maxrjones, any idea what is going on here? A few things I dont understand: The PS files are not in our GitHub anymore, just DVC. If I have a PR like this one that adds one new doc script and corresponding image but also removes a script, I have deleted that postscript file from test/baseline/module and used dvc add to update the .git file. Should I not/never delete files added to DVC? |
|
Ok, I did dvc add docs/scripts/images again and got a new .git file with 204 files. Seems fine? |
Currently, I can't see any changes in the |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7911 for background. Since plot -F is a bit obscure it can really benefit from an illustration. We had two tests for this and I have removed one of them and converted the other to a tighter and better legend figure for
plot.rst. Figure looks like this (based on old test/psxy/geosegmentize.sh that is now deleted, replaced by doc/scripts/GMT_segmentize.sh):DVC has been updated with the new and removed plots.