WIP Try to fix fill-curve issue on Linux and Windows #7959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason, GMT_fill_curves.sh does not detect the NaN gap endings or something else. This is a minor try - does it still fail?
|
I can't access my Linux machine in the next few days. So can't test it. |
|
Maybe @Esteban82 can build this branch and run the GMT_fill_curves.sh script? And @joa-quim on Windows. |
|
Yes, it fails for me on linux. |
|
But it passes for me on Win. I mean, without this PR's it already passed. |
|
Still fails on Linux. |
PaulWessel
added a commit
that referenced
this pull request
Oct 25, 2023
See #7959 for backtround. THis enables some debug output so we can compare since I cannot debug Linux directly.
PaulWessel
added a commit
that referenced
this pull request
Oct 28, 2023
* WIP Try to find issue with Linux and filled lines See #7959 for backtround. THis enables some debug output so we can compare since I cannot debug Linux directly. * CI: Temporarily trigger the tests in PR * Must wipe newly allocated structures As in other parts of GMT, if we realloc an array of structures we must manually set the new structure contents to NULL. * Revert "CI: Temporarily trigger the tests in PR" This reverts commit 58750cc. --------- Co-authored-by: Dongdong Tian <[email protected]>
|
Closed by #7975. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason, GMT_fill_curves.sh does not detect the NaN gap endings or something else. This is a minor try - does it still fail? Addresses #7957.