Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow -B when grdimage -A is used #7898

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Disallow -B when grdimage -A is used #7898

merged 2 commits into from
Oct 10, 2023

Conversation

PaulWessel
Copy link
Member

See pyGMT issue for background. This PR checks that -A and -B are not both used..

See pyGMT issue for background.  This PR checks that -A and -B are both used. Cannot allow -B when using -A to create an image.
@PaulWessel PaulWessel added the maintenance Boring but important stuff for the core devs label Oct 10, 2023
@PaulWessel PaulWessel added this to the 6.5.0 milestone Oct 10, 2023
@PaulWessel PaulWessel self-assigned this Oct 10, 2023
Copy link
Member

@joa-quim joa-quim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it could as well just warn and ignore.

@PaulWessel
Copy link
Member Author

Yes, but I think better to suppress wrong things since the -B output just confuses users.

@PaulWessel PaulWessel merged commit ce1fa02 into master Oct 10, 2023
6 checks passed
@PaulWessel PaulWessel deleted the grdimage-raster branch October 10, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants