Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix catlabels and update PS #7883

Merged
merged 2 commits into from
Oct 8, 2023
Merged

Fix catlabels and update PS #7883

merged 2 commits into from
Oct 8, 2023

Conversation

PaulWessel
Copy link
Member

Various changes needed due to improved categorical handling in #7831.

Various changes due to improved categorical handling.
@PaulWessel PaulWessel added the maintenance Boring but important stuff for the core devs label Oct 7, 2023
@PaulWessel PaulWessel added this to the 6.5.0 milestone Oct 7, 2023
@PaulWessel PaulWessel self-assigned this Oct 7, 2023
Copy link
Member

@Esteban82 Esteban82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blind approved.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified test/baseline/psscale/
modified test/baseline/psscale/catlabels.ps

Image diff(s)

Added images

Modified images

Path Old New
test/baseline/psscale/catlabels.ps

Report last updated at commit d08c592

@seisman
Copy link
Member

seisman commented Oct 7, 2023

The "Code Validator" failure is unrelated to this PR. So OK to merge.

@seisman
Copy link
Member

seisman commented Oct 8, 2023

@PaulWessel Did you forget to run dvc push?

@PaulWessel
Copy link
Member Author

Yes, did it just now.

@seisman
Copy link
Member

seisman commented Oct 8, 2023

Now the DVC diff report in #7883 (comment) looks good.

@PaulWessel PaulWessel merged commit cc44dca into master Oct 8, 2023
7 checks passed
@PaulWessel PaulWessel deleted the cat-labels branch October 8, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants