Prepare -i -o for common modifiers #7880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to have -i and -o behave similarly, I first wanted to standardize those to common structures, since -o does not have the same variables as -i. Isolated such variables in a GMT_COL_IO substructure that both common.o and common.o now use. This PR simply replaces all the common.i.* with common.i.col.* and same for common.o. No changes to functionality yet; just wanted to get these numerous changes into master before I try to expand what -o can do. Test are unchanged.
|
Not sure if @joa-quim is wrapping |
joa-quim
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have -i and -o behave similarly, I first wanted to standardise those two common structures, since -o does not have the same variables as -i (yet). I isolated such variables in a GMT_COL_IO substructure that both
GMT->common.oandGMT->common.onow use. This PR simply replaces all theGMT->common.i.*references withGMT-> common.i.col.*and the same forGMT-> common.o.No changes to functionality yet; just want to get these numerous changes into master before I try to expand what -o can do so that those changes are not buried in all the ones in this PR. Test are unchanged.