Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify grid registration in example scripts #7850

Closed
wants to merge 1 commit into from
Closed

Conversation

seisman
Copy link
Member

@seisman seisman commented Sep 29, 2023

Description of proposed changes

Address #7227

Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the non-plotting modules (grdcut, edit etc) but grdimage? It defaults to pixel registration if now given so I dont think we want to complicate the users most likely interaction which is to make plots. People who need to cut and process should know what they are doing.

@joa-quim
Copy link
Member

I go even further. What we should have is that annoying warning about since you didn't specify registration I'm defaulting to ... moved into the info verbose level. Most people don't know, or don't care (and the truth is, do we as users?) what we are talking about. If that's ok for them just let go and don't complicate the system.

@PaulWessel
Copy link
Member

I am OK with muting that annoying warning. If you dont know what you are doing then adding -V is a reasonable thing to be optional. I will take care of it.

@PaulWessel
Copy link
Member

So we have this:

is_PS = gmtinit_is_PS_module (API, mod_name, keys, options);	/* true if module will produce PS */
if (!is_PS) {	/* Override API default since module is a data processor */
	API->use_gridline_registration = true;
	API->use_gridline_registration_warn = (strcmp (mod_name, "grd2cpt") && strcmp (mod_name, "grd2kml"));	/* Give warning unless it is these two clowns */
}

so that warning only comes when you are doing data processing, in which case we felt the user need to know what they are doing and actually specify the registration. This is different from making just a map. Have you changed your mind? Don't you care if you get p or g when you do stuff with non-plotters?

@joa-quim
Copy link
Member

My stanza on it is if you care than be explicit. But note that many data processing steps are nothing but previous steps for making an image. I GMT.jl I had to add this condition to be able to read @earth_ files without having to remember every time that I had to add that -g.
https://github.com/GenericMappingTools/GMT.jl/blob/master/src/gmtreadwrite.jl#L125

@PaulWessel
Copy link
Member

OK, find I will make it INFORMATION. Not bothered either way.

@PaulWessel
Copy link
Member

Now in master

@joa-quim
Copy link
Member

Nice, and I now go catch a train.

@seisman
Copy link
Member Author

seisman commented Sep 30, 2023

I think we can close this PR now.

@seisman seisman closed this Sep 30, 2023
@seisman seisman deleted the grid-reg branch September 30, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants