Let greenspline testing not require -DDEBUG #7297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenspline has a few undocumented debug options for testing, and these were under #ifdef DEBUG - #endif sections However, I have figures that require those options and because others now also need to run those scripts I have removed the DEBUG condition so that anyone (who knows what they are doing) can accesxs these options, No tests are affected.
joa-quim
approved these changes
Mar 6, 2023
anbj
pushed a commit
that referenced
this pull request
Mar 7, 2023
* Let greenspline testing not require -DDEBUG greenspline has a few undocumented debug options for testing, and these were under #ifdef DEBUG - #endif sections However, I have figures that require those options and because others now also need to run those scripts I have removed the DEBUG condition so that anyone (who knows what they are doing) can accesxs these options, No tests are affected. * Update greenspline.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
greenspline has a few undocumented debug options for testing (-+ and -/), and these were hidden under
#ifdef DEBUG - #endifsections. However, I have illustrations that require those options and because others now also need to run those scripts I have removed the DEBUG condition so that anyone (who knows what they are doing) can access these options, No tests are affected.Note: The changes around
case WESSEL_BERCOVICI_1998_3D:would appear to be bugs since they crashed until I switched to Cube (Grid == NULL here).