Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gmtspatial.rst: fix typo #6808

Closed
wants to merge 1 commit into from
Closed

gmtspatial.rst: fix typo #6808

wants to merge 1 commit into from

Conversation

anbj
Copy link
Contributor

@anbj anbj commented Jun 20, 2022

Fix link to -W.
Please review the *distf*\[*unit*]/*distl*\[*unit*] part.
Not completely sure about this one.

@PaulWessel
Copy link
Member

OK, will have to build the docs to know I think . Did you build the docs locally and verified it looks corect?

@anbj
Copy link
Contributor Author

anbj commented Jun 20, 2022 •
edited
Loading

I did not. I could, but will have to wait until tomorrow. 'distf' and 'distl' should be slanted, right?

@PaulWessel
Copy link
Member

Yes, all italics. I am not sure how to build from a branch that is not in the regular repo...

@maxrjones
Copy link
Member

Yes, all italics. I am not sure how to build from a branch that is not in the regular repo...

git fetch origin pull/6808/head:fix-typo
git checkout fix-typo

@anbj
Copy link
Contributor Author

anbj commented Jun 20, 2022

No problem. I’ll build and test tomorrow.

@anbj
Copy link
Contributor Author

anbj commented Jun 21, 2022

I've had this problem before, but I don't remember how to fix it - any help?

$ cmake --build . --target docs_html
[  0%] Copying doc/rst/source ...
[  0%] Built target _docs_copy_rst_tree_source
[  0%] Built target _docs_rst_mkdir_verbatim
[  0%] Built target script2verbatim
[ 15%] Built target _docs_examples_verbatim
[ 16%] Copying doc/rst/_extensions ...
[ 16%] Built target _docs_copy_rst_tree__extensions
[ 16%] Copying doc/rst/themes ...
[ 16%] Built target _docs_copy_rst_tree_themes
[ 16%] Copying doc/rst/_templates ...
[ 16%] Built target _docs_copy_rst_tree__templates
[ 16%] Built target _docs_rst_src
[ 16%] Copying doc/rst/_static ...
[ 16%] Built target _docs_copy_rst_tree__static
[ 16%] Built target _docs_rst_mkdir_images
[ 20%] Built target _docs_copy_fig
[ 20%] Built target gen_gmt_headers
[ 21%] Built target pslib
[ 52%] Built target gmtlib
[ 54%] Built target gmt
[ 54%] Built target gmt_for_img_convert
gmake[3]: *** No rule to make target 'doc/scripts/images/GMT_RGBchart.ps', needed by 'doc/rst/source/_images/images/GMT_RGBchart.pdf'.  Stop.
gmake[2]: *** [CMakeFiles/Makefile2:1355: doc/scripts/CMakeFiles/_docs_html_scripts_fig.dir/all] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:1307: doc/rst/CMakeFiles/docs_html.dir/rule] Error 2
gmake: *** [Makefile:569: docs_html] Error 2

@anbj
Copy link
Contributor Author

anbj commented Jun 21, 2022

Doing docs_depends doesnt help either;

 $ cmake --build . --target docs_depends
[  0%] Copying doc/rst/source ...
[  0%] Built target _docs_copy_rst_tree_source
[  0%] Built target _docs_rst_mkdir_verbatim
[  0%] Built target script2verbatim
[ 15%] Built target _docs_examples_verbatim
[ 16%] Copying doc/rst/_extensions ...
[ 16%] Built target _docs_copy_rst_tree__extensions
[ 16%] Copying doc/rst/themes ...
[ 16%] Built target _docs_copy_rst_tree_themes
[ 16%] Copying doc/rst/_templates ...
[ 16%] Built target _docs_copy_rst_tree__templates
[ 16%] Built target _docs_rst_src
[ 16%] Copying doc/rst/_static ...
[ 16%] Built target _docs_copy_rst_tree__static
[ 16%] Built target _docs_rst_mkdir_images
[ 20%] Built target _docs_copy_fig
[ 20%] Built target gen_gmt_headers
[ 21%] Built target pslib
[ 52%] Built target gmtlib
[ 54%] Built target gmt
[ 54%] Built target gmt_for_img_convert
gmake[3]: *** No rule to make target 'doc/scripts/images/GMT_RGBchart.ps', needed by 'doc/rst/source/_images/images/GMT_RGBchart.pdf'.  Stop.
gmake[2]: *** [CMakeFiles/Makefile2:1355: doc/scripts/CMakeFiles/_docs_html_scripts_fig.dir/all] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:978: doc/rst/CMakeFiles/docs_depends.dir/rule] Error 2
gmake: *** [Makefile:413: docs_depends] Error 2

@PaulWessel
Copy link
Member

I cannot recall if you installed dvc etc and did a
dvc pull
at the top GMT directory before running those commands, but that is needed to get the latest PS files used by the docs.

@anbj
Copy link
Contributor Author

anbj commented Jun 21, 2022

I cannot recall if you installed dvc etc and did a dvc pull at the top GMT directory before running those commands, but that is needed to get the latest PS files used by the docs.

Sorry; Yes, I did.

@anbj
Copy link
Contributor Author

anbj commented Jun 21, 2022 

 $ dvc pull
Everything is up to date.

$ cmake --build . --target docs_html --parallel $(nproc)
[  1%] Copying doc/rst/source ...
[  1%] Copying doc/rst/themes ...
[  1%] Copying doc/rst/_templates ...
[  1%] Copying doc/rst/_static ...
[  1%] Built target script2verbatim
[  1%] Built target _docs_html_examples_fig
[  1%] Copying doc/rst/_extensions ...
[  1%] Built target gen_gmt_headers
[  1%] Built target _docs_copy_rst_tree_themes
[  1%] Built target _docs_copy_rst_tree__templates
[  1%] Built target _docs_copy_rst_tree__static
[  2%] Built target pslib
[  2%] Built target _docs_copy_rst_tree__extensions
[  2%] Built target _docs_copy_rst_tree_source
[  2%] Built target _docs_rst_src
[  2%] Built target _docs_rst_mkdir_images
[  2%] Built target _docs_rst_mkdir_verbatim
[ 17%] Built target _docs_examples_verbatim
[ 49%] Built target gmtlib
[ 94%] Built target _docs_scripts_verbatim
[ 97%] Built target gmt
[ 98%] Built target _docs_copy_fig
[ 98%] Built target gmt_for_img_convert
gmake[3]: *** No rule to make target 'doc/scripts/images/GMT_RGBchart.ps', needed by 'doc/rst/source/_images/images/GMT_RGBchart.pdf'.  Stop.
gmake[2]: *** [CMakeFiles/Makefile2:1355: doc/scripts/CMakeFiles/_docs_html_scripts_fig.dir/all] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:1307: doc/rst/CMakeFiles/docs_html.dir/rule] Error 2
gmake: *** [Makefile:569: docs_html] Error 2

@PaulWessel
Copy link
Member

Sorry, need smarter people like @seisman or @meghanrjones to help with this...

@PaulWessel
Copy link
Member

@meghanrjones mentioned that you do have the power of creating a PR directly on GMT Github (instead of your fork) which would make it a lot easier for us (i.e., me) to simply switch to your branch and build it.

@anbj
Copy link
Contributor Author

anbj commented Jun 21, 2022

Very interesting. When did this power flow to me?

See #6811 for new and fresh PR.

@anbj
Copy link
Contributor Author

anbj commented Jun 21, 2022 •
edited
Loading

Don't spend more time on this PR - I'll close it, but I would like to get the problems with builing the docs sorted out please.

@PaulWessel
Copy link
Member

Not sure and perhaps we forgot to tell you...but you are now a trusted entity!

@anbj
Copy link
Contributor Author

anbj commented Jun 21, 2022

I feel blessed!

@PaulWessel
Copy link
Member

I think the powers that be reasoned that since I am moving to Norway this fall we can always find you and kill you should you go rogue on us.

@anbj
Copy link
Contributor Author

anbj commented Jun 21, 2022

Shit.

@anbj anbj mentioned this pull request Jun 21, 2022
Closed
@maxrjones
Copy link
Member

Very interesting. When did this power flow to me?

See #6811 for new and fresh PR.

At the latest on October 19, 2021 🎉 For context, I created 'teams' as an easier way to manage permissions rather than setting them on an individual basis. Based on the fact that I didn't see a need to make an announcement about that change, I think it's likely that you already had write permissions before then. If that wasn't the case, sorry for not letting you know.

@anbj
Copy link
Contributor Author

anbj commented Jun 21, 2022

Thanks for the info @meghanrjones!

And, my mistake regarding problems building the docs. See #6812. Closing.

@anbj anbj closed this Jun 21, 2022
@anbj anbj deleted the fix-typo branch June 22, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anbj @PaulWessel @maxrjones