Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Pipelines CI for Windows via conda #651

Closed
wants to merge 3 commits into from
Closed

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 23, 2019

This PR adds the azure-pipelines CI for Windows. The dependencies (netcdf, gdal, et al.) are installed via conda.

The compilation takes about 12 minutes. And the simple tests all passed except the last one.

+ gmt begin
begin [ERROR]: Unable to create a workflow directory : C:/Users/VssAdministrator/.gmt/sessions/gmt6.3384

@seisman seisman requested a review from leouieda April 23, 2019 02:03
conda list
displayName: Install dependencies via conda

- bash: echo "##vso[task.setvariable variable=INSTALLDIR]D:/a/1/s/gmt-install-dir"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I use D:/a/1/s rather than $BUILD_SOURCEDIRECTORY (D:\a\1\s).

If $BUILD_SOURCEDIRECTORY is used, then

GMT->session.SHAREDIR = D:��s/gmt-install-dir/share

and gmt will fail to find some files in share directory.

mkdir -p build && cd build

# Configure
cmake .. -G "Visual Studio 15 2017 Win64" -DCMAKE_PREFIX_PATH=${CONDA}/Library
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-DCMAKE_PREFIX_PATH=${CONDA}/Library is necessary to let cmake know where to find the DLL files.

Copy link
Member

@leouieda leouieda May 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to do parallel builds? I'm surprised that it takes so much longer to compile on Windows on a Microsoft platform.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ninja does parallel builds. That's what I use.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried ninja once but failed. Have you tried Ninja on your machine? @joa-quim

@seisman seisman requested a review from joa-quim April 25, 2019 18:43
@leouieda
Copy link
Member

And the simple tests all passed except the last one.

Maybe try setting the GMT home directory to D:/a/1/s/. This seems to be a permission problem. Azure is kind of weird.

@joa-quim
Copy link
Member

I'm not sure on how I can help here. I see that the build fails because

begin [ERROR]: Unable to create a workflow directory : C:/Users/VssAdministrator/.gmt/sessions/gmt6.3384

though this is not completely new for me (I think I remember to have had people asking me about some similar problem), I never had it, so hard to debug.

Regarding the D:\a\1\s, maybe you need to escape the slashes. I.e. D:\\a\\1\\s

@seisman
Copy link
Member Author

seisman commented Apr 26, 2019

The windows build passes now. It takes ~16 minutes.

@seisman seisman force-pushed the azure-pipelines branch 5 times, most recently from 90d3a68 to 9a2a8f2 Compare May 7, 2019 04:44
@seisman
Copy link
Member Author

seisman commented May 7, 2019

@leouieda Now the Windows build takes ~9 minutes.

@seisman seisman requested a review from leouieda May 7, 2019 04:57
@seisman seisman changed the title Azure Pipelines CI for Windows Azure Pipelines CI for Windows via conda May 18, 2019
@seisman seisman closed this May 21, 2019
@seisman seisman deleted the azure-pipelines branch May 29, 2019 13:06
@seisman seisman restored the azure-pipelines branch June 5, 2019 16:24
@seisman seisman reopened this Jun 5, 2019
@seisman seisman closed this Jun 5, 2019
obaney pushed a commit to obaney/gmt that referenced this pull request Aug 18, 2021
* Improve documentation of Figure.logo()

- Fix a broken link to gmtlogo documentation
- Add option **-V**
- Remove option **-p** (not listed in the documentation)
- Add option **-S** (new in GMT 6.0)
- Option **-D** is no longer required (tested with GMT>=6.1.1)
- Remove the test for **-D**

Co-authored-by: Wei Ji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants