Fix the cmake packaging issue on macOS #6388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
changed the title
seisman
force-pushed
the
fix-macos-packaging
branch
from
717be90
to
9dc771c
Compare
seisman
force-pushed
the
fix-macos-packaging
branch
from
9dc771c
to
689181b
Compare
seisman
changed the title
|
With the workaround in this PR, the workflow now can create the macOS bundle correctly. @meghanrjones Please check if it works for you (I assume that you're a Homebrew user) |
|
Thanks for working on this. |
|
Will the bundle with this build be usable for pygmt? |
|
I think that is a separate PR that we need to work on for both Julia and PyGMT. |
|
@PaulWessel does this PR affects your bundle building with macports? |
|
Not sure, will try soon |
|
No errors on Mac ports. I have not actually tested the bundle yet, maybe on upcoming flight |
|
Build works, and running gmt coast with the installed bundle works for me on M1 macOS, macports.. |
seisman
commented
Feb 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The workflow fails to make the macOS bundle, with the following error message:
It's unclear why other libraries (like gdal) have abosulte paths, but the geos library has a relative path
@rpath/libgeos.3.10.1.dylib. So the root cause of the error is still unclear to me.A temporary workaround is passing extra RPATH (
/usr/local/libfor homebrew) as the last parameter of thefixup_bundlefunction.Fixes #6025.