New default legend symbol dimensions when no details are provided #6165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
While legend will plot exactly what you tell it to, when we now start to rely on the auto legend feature in -l there were several shortcomings. Once was the lack of a sense of the annotation font in placing the text (#6163) but also the lack of default parameters for most symbol when none is provided. And the few defaults that were there needed some adjustments as well. Before we accept these changes as is we should make sure they are adequate. Here is a plot of all the symbols that have auto-settings (historically, we had one for front but there really is no good way to know what kind of front (here squares) so it should probably be removed as auto, just like we cannot guess what quoted and decorated lines might look like:
What I mean by "no details" is simulated here by passing record like this (for circle):
S - A - red 0.5p - Star
[In -l, pen, colors, symbol type and label comes from the calling module, while size, dz1, and dx2 may be unset]
Here are issues to tackle or make decisions on:
I think the proposed PR is vastly superior to what is in master, but some tinkering can happen, and I think for consistency we should remove the auto-square setting from front so it is like the other line-embellishment symbols that need more than "-" to do anything useful.
Once this PR can be merged I can start tackling the job of adding -l to grdvector and maybe velo.
Note: No PostScript updates are presented here so you can run the tests and compare the results to see the changes.