Stop doing a "verify_sharedir_version" #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test is now failing; perhaps you can clean that part up first. |
|
Damn it. I did this PR directly from the git page and ofc didn't bother to check it builds. Seems, that I have to start over ... but latter. |
obaney
pushed a commit
to obaney/gmt
that referenced
this pull request
Aug 18, 2021
Fixes GenericMappingTools#49 Uses `GMT_Handle_Messages` to send error messages to a log file. In `call_module` retrieve those messages and use them in the exceptions for a more informative message (instead of just a status code). Implements a context manager method `LibGMT.log_to_file` that creates a temp file and sets up logging. Logs only a single API call so it must be used inside each method that wants to log. Actually only useful for `call_module`. Most other API calls don't produce error messages. Example: with self.log_to_file() as logfile: status = self._c_call_module(...) with open(logfile) as f: log = f.read()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we hard-coded most of the postscript stuff we don't need this check anymore, which can even be harmfull on Win if no /DNO_SHAREDIR_VERIFY is used and only the gmt dll is updated.