Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the svn ID with git hash in version number #6

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Conversation

leouieda
Copy link
Member

cmake inserted the svn commit ID into the version number of that the
executable prints. This replaces it with the short version of the git
commit hash (with a -dirty if there are uncommited changes.

cmake inserted the svn commit ID into the version number of that the
executable prints. This replaces it with the short version of the git
commit hash (with a `-dirty` if there are uncommited changes.
Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we can see if we have any other needs later.

@leouieda leouieda merged commit 257f544 into master Aug 13, 2018
@leouieda leouieda deleted the gitrevision branch August 13, 2018 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants