-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full in/out options to *ingrid* and *outgrid* #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with these changes
But have you read the comments in PR body? |
Sorry, no... What is the problem other than changing the docs to match reality? |
No problem, but not sure anymore what reality is. I remember that we visited this not long ago and I think we made |
Think it says(?) optional if reading the default netCDF grid format. |
The point is. Should in |
This is clearly out of scope of this (closed) PR but since I started it... The CookBook section is badly incomplete as it misses the |
It really doesn't make sense to have them separate and pass around libgmt all the time. Just makes the whole thing more complicated. This simplifies the code and removes duplication of docstrings.
But we have a problem. As it stands
grdconvert
says we need to state=ID
in order to access to +sscale, etc. But that's not what we have in https://gmt.soest.hawaii.edu/doc/latest/GMT_Docs.html#grid-file-format-specifications where=ID
is optional.