Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full in/out options to *ingrid* and *outgrid* #55

Merged
merged 2 commits into from
Sep 5, 2018
Merged

Conversation

joa-quim
Copy link
Member

@joa-quim joa-quim commented Sep 5, 2018

But we have a problem. As it stands grdconvert says we need to state =ID in order to access to +sscale, etc. But that's not what we have in https://gmt.soest.hawaii.edu/doc/latest/GMT_Docs.html#grid-file-format-specifications where =ID is optional.

Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with these changes

@PaulWessel PaulWessel merged commit 9cd3913 into master Sep 5, 2018
@PaulWessel PaulWessel deleted the grdconvert branch September 5, 2018 16:55
@joa-quim
Copy link
Member Author

joa-quim commented Sep 5, 2018

But have you read the comments in PR body?

@PaulWessel
Copy link
Member

Sorry, no... What is the problem other than changing the docs to match reality?

@joa-quim
Copy link
Member Author

joa-quim commented Sep 5, 2018

No problem, but not sure anymore what reality is. I remember that we visited this not long ago and I think we made =ID optional but it has to be provided when read/write native binary formats, so not so optional.

@PaulWessel
Copy link
Member

Think it says(?) optional if reading the default netCDF grid format.

@joa-quim
Copy link
Member Author

joa-quim commented Sep 5, 2018

The point is. Should in grdconvert we remove the part that says If =id is set (see below),?
Although true more most cases, that is a contradiction to saying that =ID is optional.

@joa-quim
Copy link
Member Author

joa-quim commented Sep 5, 2018

This is clearly out of scope of this (closed) PR but since I started it... The CookBook section is badly incomplete as it misses the :diver option that is used when saving grids in GeoTiff floats or JPK2.

obaney pushed a commit to obaney/gmt that referenced this pull request Aug 18, 2021
It really doesn't make sense to have them separate and pass around
libgmt all the time. Just makes the whole thing more complicated.
This simplifies the code and removes duplication of docstrings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants