Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete nonexistent parameters: MAP_GRID_CROSS_PEN #54

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Delete nonexistent parameters: MAP_GRID_CROSS_PEN #54

merged 1 commit into from
Sep 5, 2018

Conversation

seisman
Copy link
Member

@seisman seisman commented Sep 4, 2018

Parameters MAP_GRID_CROSS_PEN, MAP_GRID_CROSS_PEN_PRIMARY and MAP_GRID_CROSS_PEN_SECONDARY do not exist in the source code.

@welcome
Copy link

welcome bot commented Sep 4, 2018

💖 Thanks for opening this pull request! 💖

A few things to keep in mind:

  • If you need help writing tests, take a look at the existing ones for inspiration. If you don't know where to start, let us know and we'll walk you through it.
  • All new features should be documented. It helps to write the comments below for your functions describing the it, all arguments, and return types before writing the code. This will help you think about your code design and results in better code.
  • We are grateful that you put in the effort to do this! 🎉

joa-quim
joa-quim approved these changes Sep 5, 2018
View reviewed changes
Copy link
Member

@joa-quim joa-quim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, seems save to remove

@leouieda leouieda merged commit 49b8130 into master Sep 5, 2018
@welcome
Copy link

welcome bot commented Sep 5, 2018

🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉

We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

@leouieda leouieda deleted the fix-conf-docs branch September 5, 2018 02:12
obaney pushed a commit to obaney/gmt that referenced this pull request Aug 18, 2021
@leouieda
Remove mentions of GMT_TEXTSET (GenericMappingTools#54)
e3b9b2f 
This data type is no longer present in GMT.

Added an exception to the PEP8 checker that was catching the 1-letter
GMT argument I.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joa-quim joa-quim joa-quim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seisman @joa-quim @leouieda