Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -R to coast example #5313

Closed
wants to merge 1 commit into from
Closed

Add -R to coast example #5313

wants to merge 1 commit into from

Conversation

maxrjones
Copy link
Member

Description of proposed changes

The coast example in the docs did not work as written. This PR adds -R to the example.

Fixes #

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@maxrjones maxrjones requested a review from PaulWessel June 7, 2021 15:59
@seisman
Copy link
Member

seisman commented Jun 7, 2021

Isn't it a bug?

@maxrjones
Copy link
Member Author

Isn't it a bug?

This was not clear to me. I skimmed the docs and did not see any mention of an automatic -R determination happening here except when -M is used as well:

If -M is used with -E then -R or the +r modifier to -E are not required as we automatically determine the region given the selected geographic entities.

This quote from -M mentions a +r modifier to -E, but there's no +r modifier documented for -E.

@PaulWessel PaulWessel added the bug Something isn't working label Jun 7, 2021
@PaulWessel
Copy link
Member

This feature evolved from just -E to being applicable in -R, so I think some man pages may have obsolete language. That +r modifier is no longer relevant since -R sets region.
However, I think @seisman is right to consider it a bug. We have the -R available via those codes set with -E so we should not have to split it with -R. I am flagging it as a bug.

@seisman
Copy link
Member

seisman commented Jun 7, 2021

Actually, the old command without -R works well for me:

gmt coast -JM6i -Baf -EGB,IT,FR+gblue+p0.25p,red -EES,PT,GR+gyellow -pdf map

EDIT: Sorry, it doesn't.

@maxrjones
Copy link
Member Author

I'm closing this PR and have opened a bug report (#5314) instead.

@maxrjones maxrjones closed this Jun 7, 2021
@seisman seisman deleted the coast-ex branch June 7, 2021 19:03
@joa-quim
Copy link
Member

joa-quim commented Jun 7, 2021

EDIT: Sorry, it doesn't.

It does for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants