Use a separate grid index for area grid in grdfilter #5107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See this post for details. The problem was that there was the assumtion that the input grid and the area-per-node grid could share the same grid index, but in this case the input grid was a matrix with no pad while the area grid is created internally and has the regualr pad. hence different indices are needed. Now works for me.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this post for details. The actual problem was that there was an assumption that the input grid and the area-per-node grid could share the same grid index, but in this case the input grid was a matrix with no pad while the area grid is created internally and has the regular pad. Hence different indices are needed. Now works for me with the pyGMT exampe as well as passing the usual CLI tests.