Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coupe_common.rst_. Default value of -A+w #5025

Closed
wants to merge 1 commit into from

Conversation

Esteban82
Copy link
Member

The default value for -A+w is it 0, right? I add it. Not sure if the description is clear enough.

The default value for -A+w is it 0, right? I add it. Not sure if it well explain.
coupe.
@PaulWessel PaulWessel requested a review from seisman March 25, 2021 21:59
@PaulWessel
Copy link
Member

I am not sure, adding @seisman to opine.

@seisman
Copy link
Member

seisman commented Mar 25, 2021

In the new syntax, it seems p_width is uninitialized if +wwidth is not given. Does p_width=0 mean that no beachball will be plotted?

@PaulWessel
Copy link
Member

All Ctrl variables are zero an NULL when initialized, so yes p_width will be zero unless set. I just don't know if that means nothiing is plotted.

@seisman
Copy link
Member

seisman commented Mar 25, 2021

@Esteban82 What will happen if +wwidth is not given?

gmt/src/seis/pscoupe.c

Lines 1132 to 1134 in fcd0f36

if (!pscoupe_dans_coupe (in[GMT_X], in[GMT_Y], depth, Ctrl->A.xlonref, Ctrl->A.ylatref, Ctrl->A.fuseau, Ctrl->A.PREF.str,
Ctrl->A.PREF.dip, Ctrl->A.p_length, Ctrl->A.p_width, &distance, &n_dep) && !Ctrl->N.active)
continue;

As I understand the codes, the beachball will always be skipped when p_width is uninitialized (=0).

@Esteban82
Copy link
Member Author

Without +w no beachball was plot.

@seisman
Copy link
Member

seisman commented Mar 25, 2021

I think the default behavior is useless. Can we change it to infinity (means all beachballs are plotted by default)?

@PaulWessel
Copy link
Member

Yep, that is much better. I can do that.

@PaulWessel
Copy link
Member

Hi @Esteban82 I guess you can delete this branch as I did the +w default in another. Please give it a try to ensure the default (infinity) works as you expect.

@Esteban82 Esteban82 closed this Mar 26, 2021
@seisman seisman deleted the Esteban82-coupe_-A+w branch March 26, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants