Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GMT TM PostSCript #4952

Closed
wants to merge 1 commit into from
Closed

Update GMT TM PostSCript #4952

wants to merge 1 commit into from

Conversation

PaulWessel
Copy link
Member

For some reason did not fail test. @seisman why would the GMT_TM.sh test not fail when the orig had crooked annotations and the new one horizontal. Surely a large RMS. @meghanrjones even made the RMS smaller to see but still no fail?

For some reason did not fail test
@PaulWessel PaulWessel self-assigned this Mar 13, 2021
@seisman
Copy link
Member

seisman commented Mar 13, 2021

gmt/test/gmtest.in

Lines 15 to 16 in acbef76

# Is it a modern mode script?
modern=$(grep "gmt begin" "$script" -c)

It's a modern mode script, but the variable modern is incorrectly given a 0 value.

@seisman
Copy link
Member

seisman commented Mar 13, 2021

gmt/test/gmtest.in

Lines 284 to 287 in acbef76

# Modern mode needs to reestablish the $ps variable before exit
if [ "X$script_mode" = "XM" ] && [ "X$ps" = "X" ]; then
ps="${local_script%.sh}.ps"
fi

Perhaps we should change these lines to:

 if [ "X$ps" = "X" ]; then 
 	ps="${local_script%.sh}.ps" 
 fi

If the variable is empty, we should assume that the PS file is the same as the script file.

@PaulWessel
Copy link
Member Author

Ah, yes, that is a good solution.

@seisman
Copy link
Member

seisman commented Mar 13, 2021

Ah, yes, that is a good solution.

It's unclear to me whether the solution will have a bad effect on those pass-fail tests.

@PaulWessel
Copy link
Member Author

Hm, will need to look at the test script to see what a $ps variable does. I think it tries to see if the file exist before doing things. Anyway TGIF seminar in 2 minutes here....

@seisman
Copy link
Member

seisman commented Mar 13, 2021

I'll run the full tests and see how it works.

@PaulWessel
Copy link
Member Author

Maybe @meghanrjones can look at the new failures and decide if it is mostly more of the same (update PS only).

@maxrjones
Copy link
Member

Maybe @meghanrjones can look at the new failures and decide if it is mostly more of the same (update PS only).

Yes, will do.

@maxrjones
Copy link
Member

Closing this one because GMT_TM is included in #4962

@maxrjones maxrjones closed this Mar 14, 2021
@seisman seisman deleted the TM-update-PS branch March 14, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants